From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] x86 emulator: Add in/out instructions (opcodes 0xe4-0xe7, 0xec-0xef) Date: Sun, 07 Sep 2008 10:27:06 +0300 Message-ID: <48C3824A.9000907@qumranet.com> References: <20080906142229.GB8095@mohd-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Mohammed Gamal Return-path: Received: from il.qumranet.com ([212.179.150.194]:36749 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752288AbYIGH1J (ORCPT ); Sun, 7 Sep 2008 03:27:09 -0400 In-Reply-To: <20080906142229.GB8095@mohd-laptop> Sender: kvm-owner@vger.kernel.org List-ID: Mohammed Gamal wrote: > The patch adds in/out instructions to the x86 emulator. > > The instruction was encountered while running the BIOS while using > the invalid guest state emulation patch. > > Applied, thanks. > @@ -1252,6 +1255,8 @@ x86_emulate_insn(struct x86_emulate_ctxt *ctxt, struct x86_emulate_ops *ops) > u64 msr_data; > unsigned long saved_eip = 0; > struct decode_cache *c = &ctxt->decode; > + unsigned int port; > + int io_direction; > int rc = 0; > > /* Shadow copy of register state. Committed on successful emulation. > I renamed io_direction to io_dir_in as it isn't immediately clear what 0 and 1 mean with the original name. -- error compiling committee.c: too many arguments to function