From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH][REPOST] KVM: VMX: Always return 0 for clear_flush_young() when using EPT Date: Sun, 07 Sep 2008 16:31:54 +0300 Message-ID: <48C3D7CA.4030506@qumranet.com> References: <200809040929.02012.sheng.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: "Yang, Sheng" Return-path: Received: from il.qumranet.com ([212.179.150.194]:24777 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753255AbYIGNb4 (ORCPT ); Sun, 7 Sep 2008 09:31:56 -0400 In-Reply-To: <200809040929.02012.sheng.yang@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Yang, Sheng wrote: > Hi Avi > > It seems something wrong with my git-send-email, and I can't got my post from > kvm@vger.kernel.org, so resend it. Sorry for inconvenient. > - _young = _spte & PT_ACCESSED_MASK; - if (_young) { - young = 1; - clear_bit(PT_ACCESSED_SHIFT, (unsigned long *)spte); + + /* always return old for EPT */ + if (!shadow_accessed_mask) + _young = 0; + else { + _young = _spte & PT_ACCESSED_MASK; + if (_young) { + young = 1; + clear_bit(PT_ACCESSED_SHIFT, + (unsigned long *)spte); + } Why not to a if (!shadow_access_mask) return 0; in the beginning? I guess returning 'old' is safer than returning 'young'. -- error compiling committee.c: too many arguments to function