From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 00/13] RFC: out of sync shadow Date: Mon, 08 Sep 2008 17:56:16 +0300 Message-ID: <48C53D10.1030905@qumranet.com> References: <20080906184822.560099087@localhost.localdomain> <48C3B987.6020803@qumranet.com> <20080908072355.GD1014@dmt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from il.qumranet.com ([212.179.150.194]:26261 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751676AbYIHO4R (ORCPT ); Mon, 8 Sep 2008 10:56:17 -0400 In-Reply-To: <20080908072355.GD1014@dmt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > On Sun, Sep 07, 2008 at 02:22:47PM +0300, Avi Kivity wrote: > >>> VMX "bypass_guest_pf" feature on prefetch_page breaks it (since new >>> PTE writes need no TLB flush, I assume). Not sure if its worthwhile to >>> convert notrap_nonpresent -> trap_nonpresent on unshadow or just go >>> for unconditional nonpaging_prefetch_page. >>> >>> >>> >> Doesn't it kill bypass_guest_pf completely? As soon as we unsync a >> page, we can't have nontrapping nonpresent ptes in it. >> > > Yes, thats what I meant. > > We can convert those ptes during unsync, and back during resync. That's a fairly cheap operation. -- error compiling committee.c: too many arguments to function