From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 02/13] KVM: MMU: switch to get_user_pages_fast Date: Tue, 09 Sep 2008 16:57:52 +0300 Message-ID: <48C680E0.1070605@qumranet.com> References: <20080906184822.560099087@localhost.localdomain> <20080906192430.598327536@localhost.localdomain> <48C394B5.20706@qumranet.com> <20080909122138.GB14858@duo.random> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Andrea Arcangeli , kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from il.qumranet.com ([212.179.150.194]:43984 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752305AbYIIN5y (ORCPT ); Tue, 9 Sep 2008 09:57:54 -0400 In-Reply-To: <20080909122138.GB14858@duo.random> Sender: kvm-owner@vger.kernel.org List-ID: Andrea Arcangeli wrote: > On Sun, Sep 07, 2008 at 11:45:41AM +0300, Avi Kivity wrote: > >> Marcelo Tosatti wrote: >> >>> Avoid mmap_sem / pt lock acquision if the pagetables are present. The >>> improvement for hugepage backed guests is more significant, since pte >>> walk + page grab for such mappings is serialized by mm->page_table_lock. >>> >>> CC: Andrea Arcangeli >>> >>> >>> >> I'd like to apply this. Andrea, can you verify that mmu notifiers >> interaction is okay? >> > > Looks great to me. Thanks! > Thanks. Marcelo, can you split the patch into two and repost? We can get this in quickly. -- error compiling committee.c: too many arguments to function