From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: KVM: x86: do not execute halted vcpus (resend) Date: Tue, 09 Sep 2008 17:15:30 +0300 Message-ID: <48C68502.9010500@qumranet.com> References: <20080908182347.GA8457@dmt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Marcelo Tosatti Return-path: Received: from il.qumranet.com ([212.179.150.194]:48366 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753979AbYIIOPb (ORCPT ); Tue, 9 Sep 2008 10:15:31 -0400 In-Reply-To: <20080908182347.GA8457@dmt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > Offline or uninitialized vcpu's can be executed if requested to perform > userspace work. > > Follow Avi's suggestion to handle halted vcpu's in the main loop, > simplifying kvm_emulate_halt(). Introduce a new vcpu->requests bit to > indicate events that promote state from halted to running. > > Also standardize vcpu wake sites. > > Avi, please confirm that this does not break Windows reboot (which I can't > reproduce). > I couldn't reproduce it either (probably mistested earlier), so I applied it. Sorry about the drops. -- error compiling committee.c: too many arguments to function