From: Avi Kivity <avi@qumranet.com>
To: Glauber Costa <glommer@redhat.com>
Cc: Glauber Costa <gcosta@redhat.com>,
kvm@vger.kernel.org, aliguori@us.ibm.com
Subject: Re: [PATCH 0/12] Get rid of kernel memory allocation
Date: Tue, 09 Sep 2008 18:01:57 +0300 [thread overview]
Message-ID: <48C68FE5.2020604@qumranet.com> (raw)
In-Reply-To: <20080909145715.GB7490@poweredge.glommer>
Glauber Costa wrote:
>> - qemu code is formatted with 4-space indents, no tabs. your patches
>> seem to have 4-position tabs (which could only have been created by the
>> recently-opened LHC, as they don't occur naturally). please talk to
>> your editor.
>>
> Part of them. Of course one of them might have been a screw up, but mostly,
> I'm using 4 spaces for code under qemu/, and tabs for code in libkvm, which seems
> to be the standard. Should I use spaces for libkvm too?
>
No, libkvm uses those tabs. Early design error.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-09-09 15:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 19:30 [PATCH 0/12] Get rid of kernel memory allocation Glauber Costa
2008-09-08 19:30 ` [PATCH] start removing kernel memory functions Glauber Costa
2008-09-08 19:30 ` [PATCH] remove tests of user memory from vl.c Glauber Costa
2008-09-08 19:30 ` [PATCH] coalesce memory allocation Glauber Costa
2008-09-08 19:30 ` [PATCH] remove KVM_CAP_USER_MEMORY reference from qemu-kvm.c Glauber Costa
2008-09-08 19:30 ` [PATCH] remove KVM_CAP_USER_MEMORY from libkvm.c Glauber Costa
2008-09-08 19:30 ` [PATCH] remove create_kernel_phys_mem Glauber Costa
2008-09-08 19:30 ` [PATCH] get rid of kvm_create_userspace_phys_mem Glauber Costa
2008-09-08 19:30 ` [PATCH] remove user_alloc field from slot representation Glauber Costa
2008-09-08 19:30 ` [PATCH] merge destroy phys mem functions Glauber Costa
2008-09-08 19:30 ` [PATCH] rename kvm_register_userspace_phys_mem Glauber Costa
2008-09-08 19:30 ` [PATCH] remove kernel memory code from hw/pc.c Glauber Costa
2008-09-08 19:30 ` [PATCH] remove kernel memory allocation code from ipf.c Glauber Costa
2008-09-10 19:23 ` [PATCH] remove KVM_CAP_USER_MEMORY reference from qemu-kvm.c Jan Kiszka
2008-09-10 19:37 ` Glauber Costa
2008-09-10 19:59 ` Jan Kiszka
2008-09-09 14:25 ` [PATCH 0/12] Get rid of kernel memory allocation Avi Kivity
2008-09-09 14:57 ` Glauber Costa
2008-09-09 15:01 ` Avi Kivity [this message]
2008-09-10 19:20 ` [PATCH 0/12] get rid of kernel memory registration Glauber Costa
2008-09-11 8:59 ` Avi Kivity
2008-09-10 19:20 ` [PATCH 01/12] start removing kernel memory functions Glauber Costa
2008-09-10 19:20 ` [PATCH 02/12] remove tests of user memory from vl.c Glauber Costa
2008-09-10 19:20 ` [PATCH 03/12] coalesce memory allocation Glauber Costa
2008-09-10 19:20 ` [PATCH 04/12] remove KVM_CAP_USER_MEMORY reference from qemu-kvm.c Glauber Costa
2008-09-10 19:20 ` [PATCH 05/12] remove KVM_CAP_USER_MEMORY from libkvm.c Glauber Costa
2008-09-10 19:21 ` [PATCH 06/12] remove create_kernel_phys_mem Glauber Costa
2008-09-10 19:21 ` [PATCH 07/12] get rid of kvm_create_userspace_phys_mem Glauber Costa
2008-09-10 19:21 ` [PATCH 08/12] remove user_alloc field from slot representation Glauber Costa
2008-09-10 19:21 ` [PATCH 09/12] merge destroy phys mem functions Glauber Costa
2008-09-10 19:21 ` [PATCH 10/12] rename kvm_register_userspace_phys_mem Glauber Costa
2008-09-10 19:21 ` [PATCH 11/12] remove kernel memory code from hw/pc.c Glauber Costa
2008-09-10 19:21 ` [PATCH 12/12] remove kernel memory allocation code from ipf.c Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C68FE5.2020604@qumranet.com \
--to=avi@qumranet.com \
--cc=aliguori@us.ibm.com \
--cc=gcosta@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox