From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/12] Get rid of kernel memory allocation Date: Tue, 09 Sep 2008 18:01:57 +0300 Message-ID: <48C68FE5.2020604@qumranet.com> References: <1220902221-7536-1-git-send-email-gcosta@redhat.com> <48C68745.40408@qumranet.com> <20080909145715.GB7490@poweredge.glommer> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Glauber Costa , kvm@vger.kernel.org, aliguori@us.ibm.com To: Glauber Costa Return-path: Received: from il.qumranet.com ([212.179.150.194]:59597 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750871AbYIIPB6 (ORCPT ); Tue, 9 Sep 2008 11:01:58 -0400 In-Reply-To: <20080909145715.GB7490@poweredge.glommer> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: >> - qemu code is formatted with 4-space indents, no tabs. your patches >> seem to have 4-position tabs (which could only have been created by the >> recently-opened LHC, as they don't occur naturally). please talk to >> your editor. >> > Part of them. Of course one of them might have been a screw up, but mostly, > I'm using 4 spaces for code under qemu/, and tabs for code in libkvm, which seems > to be the standard. Should I use spaces for libkvm too? > No, libkvm uses those tabs. Early design error. -- error compiling committee.c: too many arguments to function