From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: KVM: x86: do not execute halted vcpus (resend) Date: Wed, 10 Sep 2008 15:04:10 +0300 Message-ID: <48C7B7BA.70405@qumranet.com> References: <20080908182347.GA8457@dmt.cnet> <48C68502.9010500@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Marcelo Tosatti Return-path: Received: from il.qumranet.com ([212.179.150.194]:20148 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752291AbYIJMEL (ORCPT ); Wed, 10 Sep 2008 08:04:11 -0400 In-Reply-To: <48C68502.9010500@qumranet.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > Marcelo Tosatti wrote: >> Offline or uninitialized vcpu's can be executed if requested to perform >> userspace work. >> Follow Avi's suggestion to handle halted vcpu's in the main loop, >> simplifying kvm_emulate_halt(). Introduce a new vcpu->requests bit to >> indicate events that promote state from halted to running. >> >> Also standardize vcpu wake sites. >> >> Avi, please confirm that this does not break Windows reboot (which I >> can't >> reproduce). >> > > I couldn't reproduce it either (probably mistested earlier), so I > applied it. Sorry about the drops. > Actually it does reproduce. If you reboot twice, the second reboot will hang during reset (with cs:ip = f000:fff0). Plain Windows XP. -- error compiling committee.c: too many arguments to function