From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] [PATCH 2/10] Allow the monitor to be suspended during non-blocking op Date: Wed, 10 Sep 2008 08:11:33 -0500 Message-ID: <48C7C785.4000402@us.ibm.com> References: <1220989802-13706-1-git-send-email-aliguori@us.ibm.com> <1220989802-13706-3-git-send-email-aliguori@us.ibm.com> <20080910100127.GD2662@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, Chris Wright , Uri Lublin , kvm@vger.kernel.org To: "Daniel P. Berrange" Return-path: Received: from e4.ny.us.ibm.com ([32.97.182.144]:35252 "EHLO e4.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752098AbYIJNM1 (ORCPT ); Wed, 10 Sep 2008 09:12:27 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e4.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m8ADCMEa020716 for ; Wed, 10 Sep 2008 09:12:22 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m8ADCMXI146992 for ; Wed, 10 Sep 2008 09:12:22 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m8ADCLRm012265 for ; Wed, 10 Sep 2008 09:12:21 -0400 In-Reply-To: <20080910100127.GD2662@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Daniel P. Berrange wrote: > On Tue, Sep 09, 2008 at 02:49:54PM -0500, Anthony Liguori wrote: > >> Live migration happens in the background, but it is useful to make the monitor >> command appear as if it's blocking. This allows a management tool to >> immediately know when the live migration has completed without having to poll >> the migration status. >> >> This patch allows the monitor to be suspended from a monitor callback which >> will prevent new monitor commands from being executed. >> > > If I'm understanding this correctly, this will cause the monitor to silently > drop & ignore any commands issued ? No. It's just like if a monitor command took a really long time. Regards, Anthony Liguori > Might it be better to have it print a > reply on the monitor along the lines of 'command not allowed while migration > is in progress' so people/apps interacting with the monitor understand why > it is not doing what they ask it to. > > Daniel >