From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH] KVM: VMX: Leave atomic context while emulating real	mode
Date: Wed, 10 Sep 2008 17:57:07 +0300
Message-ID: <48C7E043.1010505@qumranet.com>
References: <20080820140100.07333250A43@il.qumranet.com> <1221055929.4232.11.camel@frecb07144>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: KVM <kvm@vger.kernel.org>
To: Laurent Vivier <Laurent.Vivier@bull.net>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:14590 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751402AbYIJO5I (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 10 Sep 2008 10:57:08 -0400
In-Reply-To: <1221055929.4232.11.camel@frecb07144>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Laurent Vivier wrote:
>>  	int err;
>>  
>> +	preempt_enable();
>> +	local_irq_enable();
>> +
>>  	while (!guest_state_valid(vcpu)) {
>>  		err = emulate_instruction(vcpu, kvm_run, 0, 0, 0);
>>  
>> @@ -2932,6 +2935,9 @@ static void handle_invalid_guest_state(struct kvm_vcpu *vcpu,
>>  			schedule();
>>  	}
>>  
>> +	local_irq_disable();
>> +	preempt_enable();
>>     
>
> should be a preempt_disable() ?
>   

Yes.

-- 
error compiling committee.c: too many arguments to function