From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: SVM: fix guest global tlb flushes with NPT Date: Wed, 10 Sep 2008 18:08:52 +0300 Message-ID: <48C7E304.5010101@qumranet.com> References: <1220980311-32411-1-git-send-email-joerg.roedel@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Joerg Rodel Return-path: Received: from il.qumranet.com ([212.179.150.194]:16091 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751905AbYIJPIy (ORCPT ); Wed, 10 Sep 2008 11:08:54 -0400 In-Reply-To: <1220980311-32411-1-git-send-email-joerg.roedel@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: Joerg Rodel wrote: > From: Joerg Roedel > > Accesses to CR4 are intercepted even with Nested Paging enabled. But the code > does not check if the guest wants to do a global TLB flush. So this flush gets > lost. This patch adds the check and the flush to svm_set_cr4. > > Applied, thanks. I presume this does not fix the "random npt faults" we worked around earlier? -- error compiling committee.c: too many arguments to function