[PATCH] kvm: testsuite: Add test for 'call near absolute'

[PATCH] kvm: testsuite: Add test for 'call near absolute'

[Mohammed Gamal]

Adds 'call near absolute' to the real mode test harness

Signed-off-by: Mohammed Gamal <m.gamal005@gmail.com>
---
 user/test/x86/realmode.c |   21 +++++++++++++++++++++
 1 files changed, 21 insertions(+), 0 deletions(-)

diff --git a/user/test/x86/realmode.c b/user/test/x86/realmode.c
index 5f0ca0f..7da22a9 100644
--- a/user/test/x86/realmode.c
+++ b/user/test/x86/realmode.c
@@ -5,6 +5,14 @@ typedef unsigned short u16;
 typedef unsigned u32;
 typedef unsigned long long u64;
 
+void test_function(void);
+
+asm(
+	"test_function: \n\t"
+	"mov $0x1234, %eax \n\t"
+	"ret"
+   );
+
 static int strlen(const char *str)
 {
 	int n;
@@ -279,6 +287,18 @@ void test_io(struct regs *inregs, struct regs *outregs)
 
 }
 
+void test_call(struct regs *inregs, struct regs *outregs)
+{
+	MK_INSN(call1, "mov $test_function, %eax \n\t"
+		       "call *%eax\n\t");
+
+	exec_in_big_real_mode(inregs, outregs,
+		   	      insn_call1,
+			      insn_call1_end - insn_call1);
+	if(!regs_equal(inregs, outregs, R_AX) || outregs->eax != 0x1234)
+		print_serial("Call Test 1: FAIL\n");
+}
+
 void start(void)
 {
 	struct regs inregs = { 0 }, outregs;
@@ -287,6 +307,7 @@ void start(void)
 	exec_in_big_real_mode(&inregs, &outregs, 0, 0);
 	if (!regs_equal(&inregs, &outregs, 0))
 		print_serial("null test: FAIL\n");
+	test_call(&inregs, &outregs);
 	test_mov_imm(&inregs, &outregs);
 	test_io(&inregs, &outregs);
 	test_eflags_insn(&inregs, &outregs);
-- 
1.5.4.3

Re: [PATCH] kvm: testsuite: Add test for 'call near absolute'

[Avi Kivity]

Mohammed Gamal wrote:
> Adds 'call near absolute' to the real mode test harness
>   

Applied, thanks.

-- 
error compiling committee.c: too many arguments to function

[PATCH] kvm: testsuite: Add test for 'call near absolute'

[Mohammed Gamal]

Add test for 'call near abolsute' instruction to the real mode test harness

Signed-off-by: Mohammed Gamal <m.gamal005@gmail.com>
---
 user/test/x86/realmode.c |   19 +++++++++++++++++++
 1 files changed, 19 insertions(+), 0 deletions(-)

diff --git a/user/test/x86/realmode.c b/user/test/x86/realmode.c
index 5f0ca0f..756725f 100644
--- a/user/test/x86/realmode.c
+++ b/user/test/x86/realmode.c
@@ -279,6 +279,24 @@ void test_io(struct regs *inregs, struct regs *outregs)
 
 }
 
+void test_call(struct regs *inregs, struct regs *outregs)
+{
+	MK_INSN(call1, "mov $0x4000, %eax \n\t"
+		       "call *%eax\n\t");
+
+	exec_in_big_real_mode(inregs, outregs,
+		   	      insn_call1,
+			      insn_call1_end - insn_call1);
+}
+
+void line_out()
+{	
+	/* Just output a blank line */
+	asm(".org 0x4000 \n\t"
+	    "mov $10, %al \n\t"
+	    "out %al, $0xf1 \n\t");
+}
+
 void start(void)
 {
 	struct regs inregs = { 0 }, outregs;
@@ -287,6 +305,7 @@ void start(void)
 	exec_in_big_real_mode(&inregs, &outregs, 0, 0);
 	if (!regs_equal(&inregs, &outregs, 0))
 		print_serial("null test: FAIL\n");
+	test_call(&inregs, &outregs);
 	test_mov_imm(&inregs, &outregs);
 	test_io(&inregs, &outregs);
 	test_eflags_insn(&inregs, &outregs);
-- 
1.5.4.3

Re: [PATCH] kvm: testsuite: Add test for 'call near absolute'

[Avi Kivity]

Mohammed Gamal wrote:
> Add test for 'call near abolsute' instruction to the real mode test harness
>
>  
> +void test_call(struct regs *inregs, struct regs *outregs)
> +{
> +	MK_INSN(call1, "mov $0x4000, %eax \n\t"
> +		       "call *%eax\n\t");
> +
> +	exec_in_big_real_mode(inregs, outregs,
> +		   	      insn_call1,
> +			      insn_call1_end - insn_call1);
>   

Please test registers for damage (using regs_equal).

> +}
> +
> +void line_out()
> +{	
> +	/* Just output a blank line */
> +	asm(".org 0x4000 \n\t"
> +	    "mov $10, %al \n\t"
> +	    "out %al, $0xf1 \n\t");
> +}
>   

When the code grows and occupies address 0x4000, this will break.

I suggest:

void test_function(void);
asm ("test_function: mov $1234, %eax; ret");

This sets up a register to see that the call actually did something, and 
avoids the gcc function prologue/epilogue which may clobber registers.



-- 
error compiling committee.c: too many arguments to function