public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: kvm-devel <kvm@vger.kernel.org>
Subject: [PATCH] i440fx: do change ISA mappings under KVM
Date: Wed, 10 Sep 2008 21:34:44 +0200	[thread overview]
Message-ID: <48C82154.4030109@web.de> (raw)

As long as KVM does not support remapping or protection state changes of
guest memory, do not fiddle with the ISA mappings that QEMU see,
confusing both the monitor and the gdbstub.

Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
---
 qemu/hw/piix_pci.c |    6 ++++++
 1 file changed, 6 insertions(+)

Index: b/qemu/hw/piix_pci.c
===================================================================
--- a/qemu/hw/piix_pci.c
+++ b/qemu/hw/piix_pci.c
@@ -26,6 +26,8 @@
 #include "pc.h"
 #include "pci.h"
 
+#include "qemu-kvm.h"
+
 typedef uint32_t pci_addr_t;
 #include "pci_host.h"
 
@@ -91,6 +93,10 @@ static void i440fx_update_memory_mapping
     int i, r;
     uint32_t smram, addr;
 
+    if (kvm_enabled()) {
+        /* FIXME: Support remappings and protection changes. */
+        return;
+    }
     update_pam(d, 0xf0000, 0x100000, (d->config[0x59] >> 4) & 3);
     for(i = 0; i < 12; i++) {
         r = (d->config[(i >> 1) + 0x5a] >> ((i & 1) * 4)) & 3;

             reply	other threads:[~2008-09-10 19:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-10 19:34 Jan Kiszka [this message]
2008-09-11 10:06 ` [PATCH] i440fx: do change ISA mappings under KVM Avi Kivity
2008-09-11 10:57   ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48C82154.4030109@web.de \
    --to=jan.kiszka@web.de \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox