From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 2/2] KVM: switch to get_user_pages_fast Date: Thu, 11 Sep 2008 17:06:30 +0300 Message-ID: <48C925E6.5070009@qumranet.com> References: <20080911134340.714935482@localhost.localdomain> <20080911134425.012616301@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Hollis Blanchard To: Marcelo Tosatti Return-path: Received: from il.qumranet.com ([212.179.150.194]:56560 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751643AbYIKOGc (ORCPT ); Thu, 11 Sep 2008 10:06:32 -0400 In-Reply-To: <20080911134425.012616301@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > Convert gfn_to_pfn to use get_user_pages_fast, which can do lockless > pagetable lookups on x86. Kernel compilation on 4-way guest is 3.7% > faster on VMX. > > Hollis, can you fix kvmppc_mmu_map? gfn_to_page must not be called with > mmap_sem held. > > Looks tricky: > /* Must be called with mmap_sem locked for writing. */ > static void kvmppc_44x_shadow_release(struct kvm_vcpu *vcpu, > > Signed-off-by: Marcelo Tosatti > CC: Hollis Blanchard > > I'll wait until this is resolved, since I don't want to break ppc. -- error compiling committee.c: too many arguments to function