From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] usb: Support for removing device by host addr, improved auto filter syntax Date: Thu, 11 Sep 2008 16:01:44 -0500 Message-ID: <48C98738.5060204@codemonkey.ws> References: <1220679644-8043-1-git-send-email-maxk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: aurelien@aurel32.net, qemu-devel@nongnu.org, kvm@vger.kernel.org To: Max Krasnyansky Return-path: Received: from an-out-0708.google.com ([209.85.132.245]:15284 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753532AbYIKVCg (ORCPT ); Thu, 11 Sep 2008 17:02:36 -0400 Received: by an-out-0708.google.com with SMTP id d40so65202and.103 for ; Thu, 11 Sep 2008 14:02:35 -0700 (PDT) In-Reply-To: <1220679644-8043-1-git-send-email-maxk@kernel.org> Sender: kvm-owner@vger.kernel.org List-ID: Max Krasnyansky wrote: > This patch adds support for removing USB devices by host address. > Which is usefull for things like libvirtd because there is no easy way to > find guest USB address of the host device. > In other words you can now do: > usb_add host:3.5 > ... > usb_del host:3.5 > Before the patch 'usb_del' did not support 'host:' notation. > > This patch breaks the windows build with: i686-pc-mingw32-gcc -Wall -O2 -g -fno-strict-aliasing -m32 -I. -I/home/anthony/svn/qemu -MMD -MP -MT usb-linux.o -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -I/home/anthony/svn/qemu/slirp -c -o usb-linux.o /home/anthony/svn/qemu/usb-linux.c /home/anthony/svn/qemu/usb-linux.c:1205: error: conflicting types for 'usb_host_device_close' /home/anthony/svn/qemu/hw/usb.h:243: error: previous declaration of 'usb_host_device_close' was here make: *** [usb-linux.o] Error 1 Regards, Anthony Liguori