From mboxrd@z Thu Jan  1 00:00:00 1970
From: Max Krasnyansky <maxk@kernel.org>
Subject: Re: [PATCH] usb: Support for removing device by host addr, improved
 auto filter syntax
Date: Thu, 11 Sep 2008 20:48:52 -0700
Message-ID: <48C9E6A4.1070402@kernel.org>
References: <1220679644-8043-1-git-send-email-maxk@kernel.org> <48C98738.5060204@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: aurelien@aurel32.net, qemu-devel@nongnu.org, kvm@vger.kernel.org
To: Anthony Liguori <anthony@codemonkey.ws>
Return-path: <kvm-owner@vger.kernel.org>
Received: from hera.kernel.org ([140.211.167.34]:38191 "EHLO hera.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751810AbYILDtX (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 11 Sep 2008 23:49:23 -0400
In-Reply-To: <48C98738.5060204@codemonkey.ws>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Anthony Liguori wrote:
> Max Krasnyansky wrote:
>> This patch adds support for removing USB devices by host address.
>> Which is usefull for things like libvirtd because there is no easy way to
>> find guest USB address of the host device.
>> In other words you can now do:
>>    usb_add host:3.5
>>    ...
>>    usb_del host:3.5
>> Before the patch 'usb_del' did not support 'host:' notation.
>>
>>   
> 
> This patch breaks the windows build with:
> 
> i686-pc-mingw32-gcc -Wall -O2 -g -fno-strict-aliasing  -m32 -I.
> -I/home/anthony/svn/qemu -MMD -MP -MT usb-linux.o -D_GNU_SOURCE
> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
> -I/home/anthony/svn/qemu/slirp -c -o usb-linux.o
> /home/anthony/svn/qemu/usb-linux.c
> /home/anthony/svn/qemu/usb-linux.c:1205: error: conflicting types for
> 'usb_host_device_close'
> /home/anthony/svn/qemu/hw/usb.h:243: error: previous declaration of
> 'usb_host_device_close' was here
> make: *** [usb-linux.o] Error 1

I'll take a look and resend. Thanx for testing.

Max