From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH] Fix COMPAT_csum_offset #endif in virtio_net.c
Date: Sat, 13 Sep 2008 08:05:34 +0300
Message-ID: <48CB4A1E.7050001@qumranet.com>
References: <20080825124235.GA27216@tolk.kyne.com.au> <1221068116.31151.11.camel@blaa>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Mark Pulford <mark@kyne.com.au>, kvm@vger.kernel.org
To: Mark McLoughlin <markmc@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:22201 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751008AbYIMFIB (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 13 Sep 2008 01:08:01 -0400
In-Reply-To: <1221068116.31151.11.camel@blaa>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Mark McLoughlin wrote:
> On Mon, 2008-08-25 at 22:12 +0930, Mark Pulford wrote:
>   
>> Fix COMPAT_csum_offset #else/#endif block in virtio_net.c. The #endif
>> was being output 1 line too early.
>>
>> Signed-off-by: Mark Pulford <mark@kyne.com.au>
>>
>> diff --git a/hack-module.awk b/hack-module.awk
>> index a3275fa..7cb9381 100644
>> --- a/hack-module.awk
>> +++ b/hack-module.awk
>> @@ -134,6 +134,9 @@
>>      print "\t\thdr->csum_start = skb->h.raw - skb->data;";
>>      print "\t\thdr->csum_offset = skb->csum;";
>>      print "#else"
>> +}
>> +
>> +/hdr->csum_offset = skb->csum_offset/ {
>>      need_endif = 1;
>>  }
>>     
>
> This looks right to me; I had a slightly uglier version that I forgot to
> upstream.
>
> Acked-by: Mark McLoughlin <markmc@redhat.com>
>
>   

Thanks for the reminder; applied.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.