kvm userland: configure does not check for gawk

kvm userland: configure does not check for gawk

[Ben Bucksch]

If gawk is not installed, the build reports "gawk not found", but then 
fails with strange errors about kvm.h having the wrong version, mismatch 
between kernel and userland, and even more resulting errors later on. 
This sent me off the wrong trail.

Please:

   1. Check that all apps used in the build process are checked in
      configure and reported right there. Esp. gawk in this case.
   2. Improve the version check to not say "version mismatch" when the
      kvm.h file does not exist at all or is entirely empty, i.e.
      KVM_API_VERSION is empty.

Re: kvm userland: configure does not check for gawk

[Brian Jackson]

Maybe something like this is in order:

diff --git a/configure b/configure
index 3bb10ce..efbfa24 100755
--- a/configure
+++ b/configure
@@ -102,6 +102,11 @@ if [ "$arch" = "powerpc" ]; then
     qemu_ldflags="$qemu_ldflags -L $PWD/libfdt"
 fi

+# check for some utils we use
+if [ -d .git -a ! -x "`which gawk`" ] ; then
+    echo "gawk not installed and necessary for compiling from git"
+fi
+
 #configure user dir
 (cd user; ./configure --prefix="$prefix" --kerneldir="$libkvm_kerneldir" \
           --arch="$arch" \


On Tuesday 09 September 2008 10:15:00 pm Ben Bucksch wrote:
> If gawk is not installed, the build reports "gawk not found", but then
> fails with strange errors about kvm.h having the wrong version, mismatch
> between kernel and userland, and even more resulting errors later on.
> This sent me off the wrong trail.
>
> Please:
>
>    1. Check that all apps used in the build process are checked in
>       configure and reported right there. Esp. gawk in this case.
>    2. Improve the version check to not say "version mismatch" when the
>       kvm.h file does not exist at all or is entirely empty, i.e.
>       KVM_API_VERSION is empty.
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: kvm userland: configure does not check for gawk

[Brian Jackson]

Or we could try a correct version:

diff --git a/configure b/configure
index 3bb10ce..5cac4c8 100755
--- a/configure
+++ b/configure
@@ -102,6 +102,12 @@ if [ "$arch" = "powerpc" ]; then
     qemu_ldflags="$qemu_ldflags -L $PWD/libfdt"
 fi

+# check for some utils we use
+if [ -d .git -a ! -x "`which gawk`" ] ; then
+    echo "gawk not installed and necessary for compiling from git"
+    exit
+fi
+
 #configure user dir
 (cd user; ./configure --prefix="$prefix" --kerneldir="$libkvm_kerneldir" \
           --arch="$arch" \


On Tuesday 09 September 2008 11:16:03 pm Brian Jackson wrote:
> Maybe something like this is in order:
>
> diff --git a/configure b/configure
> index 3bb10ce..efbfa24 100755
> --- a/configure
> +++ b/configure
> @@ -102,6 +102,11 @@ if [ "$arch" = "powerpc" ]; then
>      qemu_ldflags="$qemu_ldflags -L $PWD/libfdt"
>  fi
>
> +# check for some utils we use
> +if [ -d .git -a ! -x "`which gawk`" ] ; then
> +    echo "gawk not installed and necessary for compiling from git"
> +fi
> +
>  #configure user dir
>  (cd user; ./configure --prefix="$prefix" --kerneldir="$libkvm_kerneldir" \
>            --arch="$arch" \
>
> On Tuesday 09 September 2008 10:15:00 pm Ben Bucksch wrote:
> > If gawk is not installed, the build reports "gawk not found", but then
> > fails with strange errors about kvm.h having the wrong version, mismatch
> > between kernel and userland, and even more resulting errors later on.
> > This sent me off the wrong trail.
> >
> > Please:
> >
> >    1. Check that all apps used in the build process are checked in
> >       configure and reported right there. Esp. gawk in this case.
> >    2. Improve the version check to not say "version mismatch" when the
> >       kvm.h file does not exist at all or is entirely empty, i.e.
> >       KVM_API_VERSION is empty.
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe kvm" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: kvm userland: configure does not check for gawk

[Avi Kivity]

Brian Jackson wrote:
> Or we could try a correct version:
>
> diff --git a/configure b/configure
> index 3bb10ce..5cac4c8 100755
> --- a/configure
> +++ b/configure
> @@ -102,6 +102,12 @@ if [ "$arch" = "powerpc" ]; then
>      qemu_ldflags="$qemu_ldflags -L $PWD/libfdt"
>  fi
>
> +# check for some utils we use
> +if [ -d .git -a ! -x "`which gawk`" ] ; then
> +    echo "gawk not installed and necessary for compiling from git"
> +    exit
> +fi
> +
>   

'exit 1', and a changelog+signoff.


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.