From mboxrd@z Thu Jan 1 00:00:00 1970 From: Iain Paton Subject: Re: kvm userland: Build misses -I Date: Sun, 14 Sep 2008 11:28:06 +0100 Message-ID: <48CCE736.5020004@darkvoyage.org.uk> References: <48C73CBF.3070605@bucksch.org> <48CB4CC8.5050903@qumranet.com> <48CBBB19.4050306@bucksch.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Avi Kivity , kvm@vger.kernel.org To: Ben Bucksch Return-path: Received: from defiant.darkvoyage.org.uk ([81.187.177.18]:60977 "EHLO defiant.darkvoyage.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752639AbYINK2N (ORCPT ); Sun, 14 Sep 2008 06:28:13 -0400 In-Reply-To: <48CBBB19.4050306@bucksch.org> Sender: kvm-owner@vger.kernel.org List-ID: Ben Bucksch wrote: > Reason is, as said, that the build assumes that > /usr/include/linux/ioctl.h exists, i.e. it just #include Oh, that's not nice. Certainly for me /usr/include/linux will never point to the kernel I'm building against so that's just a problem waiting to happen. > , but does not pass the kernel dir *that I explicitly passed to > configure* to gcc. If I explicitly pass the kernel dir to configure, I > expect that to be used, and only that. Seconded. Especially when building external modules the only path being used should be the one passed in as the KERNELDIR I want to build against. Using /usr/include/linux or something under /lib/modules/$(uname -r)/build is fraught with problems. > iggy on IRC noted that kernel source and build dir may be separate. > That's true - you probably need two configure flags --kernel-source-dir > and --kernel-build-dir. The existing --kerneldir could stay and set both > to the same value. That's the issue I found with kvm-74, building the kernel with O= to have seperate source and build dirs fails as the makefile for the external kvm modules assumes that isn't an option. There's a very minimal patch to get that working in this post: Iain