From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Device Assignment with VT-d Date: Tue, 16 Sep 2008 11:18:30 -0700 Message-ID: <48CFF876.8000801@redhat.com> References: <20080916005853.7876D250DB2@il.qumranet.com> <1221568935.4172.22.camel@frecb07144> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Laurent Vivier Return-path: Received: from mx2.redhat.com ([66.187.237.31]:53997 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754176AbYIPSUR (ORCPT ); Tue, 16 Sep 2008 14:20:17 -0400 In-Reply-To: <1221568935.4172.22.camel@frecb07144> Sender: kvm-owner@vger.kernel.org List-ID: Laurent Vivier wrote: >> @@ -1147,6 +1157,9 @@ int kvm_dev_ioctl_check_extension(long ext) >> case KVM_CAP_PV_MMU: >> r = !tdp_enabled; >> break; >> + case KVM_CAP_IOMMU: >> + r = intel_iommu_found(); >> + break; >> > > Must depend on CONFIG_DMAR too > Rather, intel_iommu_found() should be defined (and return zero) if !CONFIG_DMAR. (what's a dmar?) -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.