From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Device Assignment: Free device structures if IRQ allocation fails Date: Tue, 16 Sep 2008 15:03:55 -0700 Message-ID: <48D02D4B.7050105@redhat.com> References: <1221378495-13933-1-git-send-email-amit.shah@qumranet.com> <48CFEC09.9050704@qumranet.com> <200809162303.17762.amit.shah@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, benami@il.ibm.com To: Amit Shah Return-path: Received: from mx2.redhat.com ([66.187.237.31]:54586 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751971AbYIPWGu (ORCPT ); Tue, 16 Sep 2008 18:06:50 -0400 In-Reply-To: <200809162303.17762.amit.shah@qumranet.com> Sender: kvm-owner@vger.kernel.org List-ID: Amit Shah wrote: > * On Tuesday 16 Sep 2008 22:55:29 Avi Kivity wrote: > >> Amit Shah wrote: >> >>> When an IRQ allocation fails, we free up the device structures and >>> disable the device so that we can unregister the device in the userspace >>> and not expose it to the guest at all. >>> >> Still doesn't apply. What did you generate this against? >> > > Please use the newer one that I sent you a while back. > Okay, got it. The [PATCH v18] thing can help prevent such confusion. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.