From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uri Lublin Subject: Re: Problem adding new source files Date: Thu, 18 Sep 2008 16:18:28 +0300 Message-ID: <48D25524.7060601@qumranet.com> References: <43BCF5BD5ADA674C839A0242AC72B32B01244BCD@dewdfe1f.wdf.sap.corp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: "Hacking, Stuart" Return-path: Received: from mis011-1.exch011.intermedia.net ([64.78.17.182]:16126 "EHLO mis011-1.exch011.intermedia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753107AbYIRNdq (ORCPT ); Thu, 18 Sep 2008 09:33:46 -0400 In-Reply-To: <43BCF5BD5ADA674C839A0242AC72B32B01244BCD@dewdfe1f.wdf.sap.corp> Sender: kvm-owner@vger.kernel.org List-ID: Hacking, Stuart wrote: > Hello, Hi, > > We have been doing some experimentation with modifications to the > migration code in the Qemu and came up against a problem. We included > some code in a different file and are receiving the following error from > make: > > --- > Migration.o: In function `migrate_prepare_page': > /root/tmp/KVM/qemu/migration.c:367: undefined reference to > `get_cached_page' > /root/tmp/KVM/qemu/migration.c:367: undefined reference to > `get_cached_page' > /root/tmp/KVM/qemu/migration.c:367: undefined reference to > `get_cached_page' > collect2: ld returned 1 exit status > Make[2]: *** [qemu-system_x86_64] Error 1 > Make[1]: *** [subdir-x86_64-softmmu] Error2 > Make: *** [qemu] Error 2 > --- Did you define new functions in a different .c file(s) ? Did you provide prototypes for all new functions ? Did you add all new files to the Makefile ? > > We see from looking at the code that everything seems to be correct and > we suspect that the error is coming from the order that the files are > being compiled. Is there any special consideration we need to take when > adding new headers and code files to the tree? (at the minute any new > files we added are in the same directory as migration.c.) > > We aren't sure if the kvm maintainers are using a custom makefile, > however, would it be more appropriate to post this on the Qemu mailing > list? Speculations... I'm sure kvm maintainer and developers (and users) use the released Makefile. Regards, Uri.