From: Uri Lublin <uril@qumranet.com>
To: "Hacking, Stuart" <stuart.hacking@sap.com>
Cc: kvm@vger.kernel.org
Subject: Re: Problem adding new source files
Date: Thu, 18 Sep 2008 19:01:23 +0300 [thread overview]
Message-ID: <48D27B53.6070009@qumranet.com> (raw)
In-Reply-To: <43BCF5BD5ADA674C839A0242AC72B32B01293416@dewdfe1f.wdf.sap.corp>
Hacking, Stuart wrote:
>> From: Uri Lublin [mailto:uril@qumranet.com]
>> Hacking, Stuart wrote:
>>> Hello,
>> Hi,
>>>
>>> We have been doing some experimentation with modifications to the
>>> migration code in the Qemu and came up against a problem.
>> We included
>>> some code in a different file and are receiving the following error
>>> from
>>> make:
>>>
>>> ---
>>> Migration.o: In function `migrate_prepare_page':
>>> /root/tmp/KVM/qemu/migration.c:367: undefined reference to
>>> `get_cached_page'
>>> /root/tmp/KVM/qemu/migration.c:367: undefined reference to
>>> `get_cached_page'
>>> /root/tmp/KVM/qemu/migration.c:367: undefined reference to
>>> `get_cached_page'
>>> collect2: ld returned 1 exit status
>>> Make[2]: *** [qemu-system_x86_64] Error 1
>>> Make[1]: *** [subdir-x86_64-softmmu] Error2
>>> Make: *** [qemu] Error 2
>>> ---
>> Did you define new functions in a different .c file(s) ? Did
>> you provide prototypes for all new functions ? Did you add
>> all new files to the Makefile ?
>>
>
> As far as I know all the code is organised properly and the function
> prototypes provided in header files. As for adding to the Makefile -
> that's where we are struggling. We have tried the following
> 'experiments': adding our new source files to the 'OBJS' variable
> (OBJS+=s1.o s2.o); creating a migration.o directive which depends on
> s1.o and s2.o (this actually produces a slightly different error:
>
Try just adding your new .o files (e.g: OBJS+=s1.o s2.o) to
<kvmdir>/qemu/Makefile.target
next prev parent reply other threads:[~2008-09-18 16:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 11:56 Problem adding new source files Hacking, Stuart
2008-09-18 13:18 ` Uri Lublin
2008-09-18 15:09 ` Hacking, Stuart
2008-09-18 16:01 ` Uri Lublin [this message]
2008-09-19 13:23 ` Hacking, Stuart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D27B53.6070009@qumranet.com \
--to=uril@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=stuart.hacking@sap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox