From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "Xu, Jiajun" <jiajun.xu@intel.com>,
kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>,
Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH] add compat wrapper for get_user_pages_fast
Date: Fri, 19 Sep 2008 16:52:14 -0700 [thread overview]
Message-ID: <48D43B2E.5020002@redhat.com> (raw)
In-Reply-To: <48D282C0.3050100@siemens.com>
Jan Kiszka wrote:
> Not sure if this is correct, but here is at least a compile fix.
>
>
I think it is.
> Note that the original mmem_map locking scope was partly far broader on
> older kernels than with Marcelo's patch and this fix now. Could anyone
> comment on the correctness?
>
Since get_user_pages_fast() falls back to your code sequence, this is at
least as safe as mainline. So I applied it, thanks.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2008-09-19 23:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 3:17 KVM Build error with 2.6.26 Xu, Jiajun
2008-09-18 8:25 ` Jan Kiszka
2008-09-18 16:33 ` [PATCH] add compat wrapper for get_user_pages_fast Jan Kiszka
2008-09-18 22:30 ` Marcelo Tosatti
2008-09-19 23:52 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D43B2E.5020002@redhat.com \
--to=avi@redhat.com \
--cc=avi@qumranet.com \
--cc=jan.kiszka@siemens.com \
--cc=jiajun.xu@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox