From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] add compat wrapper for get_user_pages_fast Date: Fri, 19 Sep 2008 16:52:14 -0700 Message-ID: <48D43B2E.5020002@redhat.com> References: <48D21065.5090602@siemens.com> <48D282C0.3050100@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Xu, Jiajun" , kvm@vger.kernel.org, Marcelo Tosatti , Avi Kivity To: Jan Kiszka Return-path: Received: from il.qumranet.com ([212.179.150.194]:35076 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752539AbYISXwM (ORCPT ); Fri, 19 Sep 2008 19:52:12 -0400 In-Reply-To: <48D282C0.3050100@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > Not sure if this is correct, but here is at least a compile fix. > > I think it is. > Note that the original mmem_map locking scope was partly far broader on > older kernels than with Marcelo's patch and this fix now. Could anyone > comment on the correctness? > Since get_user_pages_fast() falls back to your code sequence, this is at least as safe as mainline. So I applied it, thanks. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.