From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Avi Kivity <avi@qumranet.com>,
kvm@vger.kernel.org, "David S. Ahern" <daahern@cisco.com>
Subject: Re: [patch 02/10] KVM: MMU: move local TLB flush to mmu_set_spte
Date: Fri, 19 Sep 2008 17:21:09 -0700 [thread overview]
Message-ID: <48D441F5.5000707@redhat.com> (raw)
In-Reply-To: <20080918213336.548424061@localhost.localdomain>
Marcelo Tosatti wrote:
> Since the sync page path can collapse flushes.
>
> Also only flush if the spte was writable before.
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> @@ -1241,9 +1239,12 @@ static void mmu_set_spte(struct kvm_vcpu
> }
> }
> if (set_spte(vcpu, shadow_pte, pte_access, user_fault, write_fault,
> - dirty, largepage, gfn, pfn, speculative))
> + dirty, largepage, gfn, pfn, speculative)) {
> if (write_fault)
> *ptwrite = 1;
> + if (was_writeble)
> + kvm_x86_ops->tlb_flush(vcpu);
> + }
>
>
I think we had cases where the spte.pfn contents changed, for example
when a large page was replaced by a normal page, and also:
} else if (pfn != spte_to_pfn(*shadow_pte)) {
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2008-09-20 0:21 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 21:27 [patch 00/10] out of sync shadow v2 Marcelo Tosatti
2008-09-18 21:27 ` [patch 01/10] KVM: MMU: split mmu_set_spte Marcelo Tosatti
2008-09-18 21:27 ` [patch 02/10] KVM: MMU: move local TLB flush to mmu_set_spte Marcelo Tosatti
2008-09-20 0:21 ` Avi Kivity [this message]
2008-09-18 21:27 ` [patch 03/10] KVM: MMU: do not write-protect large mappings Marcelo Tosatti
2008-09-20 0:29 ` Avi Kivity
2008-09-21 0:41 ` Marcelo Tosatti
2008-09-18 21:27 ` [patch 04/10] KVM: MMU: mode specific sync_page Marcelo Tosatti
2008-09-20 0:44 ` Avi Kivity
2008-09-18 21:27 ` [patch 05/10] KVM: MMU: sync roots on mmu reload Marcelo Tosatti
2008-09-18 21:27 ` [patch 06/10] KVM: x86: trap invlpg Marcelo Tosatti
2008-09-20 0:53 ` Avi Kivity
2008-09-21 0:43 ` Marcelo Tosatti
2008-09-18 21:27 ` [patch 07/10] KVM: MMU: mmu_parent_walk Marcelo Tosatti
2008-09-20 0:56 ` Avi Kivity
2008-09-21 0:44 ` Marcelo Tosatti
2008-09-22 20:30 ` Avi Kivity
2008-09-22 22:04 ` Marcelo Tosatti
2008-09-18 21:27 ` [patch 08/10] KVM: MMU: awareness of new kvm_mmu_zap_page behaviour Marcelo Tosatti
2008-09-18 21:27 ` [patch 09/10] KVM: MMU: out of sync shadow core v2 Marcelo Tosatti
2008-09-20 1:22 ` Avi Kivity
2008-09-21 0:45 ` Marcelo Tosatti
2008-09-22 20:41 ` Avi Kivity
2008-09-22 21:55 ` Marcelo Tosatti
2008-09-22 22:51 ` Marcelo Tosatti
2008-09-23 10:46 ` Avi Kivity
2008-09-23 10:46 ` Avi Kivity
2008-09-23 13:17 ` Marcelo Tosatti
2008-09-18 21:27 ` [patch 10/10] KVM: MMU: speed up mmu_unsync_walk Marcelo Tosatti
2008-09-20 1:26 ` Avi Kivity
2008-09-21 0:45 ` Marcelo Tosatti
2008-09-22 20:43 ` Avi Kivity
2008-09-18 22:36 ` [patch 00/10] out of sync shadow v2 Marcelo Tosatti
2008-09-20 1:28 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2008-09-21 0:10 [patch 02/10] KVM: MMU: move local TLB flush to mmu_set_spte Marcelo Tosatti
2008-09-22 20:26 ` Avi Kivity
2008-09-22 21:56 ` Marcelo Tosatti
2008-09-22 20:28 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D441F5.5000707@redhat.com \
--to=avi@redhat.com \
--cc=avi@qumranet.com \
--cc=daahern@cisco.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox