From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [patch 06/10] KVM: x86: trap invlpg
Date: Fri, 19 Sep 2008 17:53:22 -0700
Message-ID: <48D44982.1000209@redhat.com>
References: <20080918212749.800177179@localhost.localdomain> <20080918213336.890811059@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@qumranet.com>, kvm@vger.kernel.org,
	"David S. Ahern" <daahern@cisco.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:38167 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751408AbYITAxT (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 19 Sep 2008 20:53:19 -0400
In-Reply-To: <20080918213336.890811059@localhost.localdomain>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Marcelo Tosatti wrote:
>  
> +static int FNAME(shadow_invlpg_entry)(struct kvm_shadow_walk *_sw,
> +				      struct kvm_vcpu *vcpu, u64 addr,
> +				      u64 *sptep, int level)
> +{
> +
> +	if (level == PT_PAGE_TABLE_LEVEL) {
> +		if (is_shadow_present_pte(*sptep))
> +			rmap_remove(vcpu->kvm, sptep);
> +		set_shadow_pte(sptep, shadow_trap_nonpresent_pte);
>   

Need to flush the real tlb as well.


-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.