From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 00/10] out of sync shadow v2 Date: Fri, 19 Sep 2008 18:28:16 -0700 Message-ID: <48D451B0.1060608@redhat.com> References: <20080918212749.800177179@localhost.localdomain> <20080918223650.GB24183@dmt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Avi Kivity , kvm@vger.kernel.org, "David S. Ahern" To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:36234 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752785AbYITB2R (ORCPT ); Fri, 19 Sep 2008 21:28:17 -0400 In-Reply-To: <20080918223650.GB24183@dmt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > On Thu, Sep 18, 2008 at 06:27:49PM -0300, Marcelo Tosatti wrote: > >> Addressing earlier comments. >> > > Ugh, forgot to convert shadow_notrap -> shadow_trap on unsync, > so bypass_guest_pf=1 is still broken. > > > Also, forgot the nice benchmark results. I really like this (at least the parts I understand, which I believe are most of the patchset). This looks much closer to merging. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.