From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 4/9] substitute is_allocated_mem with more general is_containing_region
Date: Sat, 20 Sep 2008 11:33:56 -0700
Message-ID: <48D54214.5080501@redhat.com>
References: <1221840506-22996-1-git-send-email-glommer@redhat.com> <1221840506-22996-5-git-send-email-glommer@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, aliguori@us.ibm.com
To: Glauber Costa <glommer@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:52293 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751344AbYITSeT (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 20 Sep 2008 14:34:19 -0400
In-Reply-To: <1221840506-22996-5-git-send-email-glommer@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Glauber Costa wrote:
> is_allocated_mem is a function that checks if every relevant aspect of the memory slot
> match (start and size). Replace it with a more generic function that checks if a memory
> region is totally contained into another. The former case is also covered.
>   

I think enabling dirty page tracking requires the slot to match exactly.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.