From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 5/9] add debuging facilities to memory registration at
 libkvm
Date: Sat, 20 Sep 2008 11:34:55 -0700
Message-ID: <48D5424F.1020703@redhat.com>
References: <1221840506-22996-1-git-send-email-glommer@redhat.com> <1221840506-22996-6-git-send-email-glommer@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, aliguori@us.ibm.com
To: Glauber Costa <glommer@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:52358 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751028AbYITSfU (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 20 Sep 2008 14:35:20 -0400
In-Reply-To: <1221840506-22996-6-git-send-email-glommer@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Glauber Costa wrote:
> +#ifdef DEBUG_MEMREG
> +	fprintf(stderr, "%s, memory: gpa: %llx, size: %llx, uaddr: %llx, slot: %x, flags: %lx\n",
> +		__func__, memory.guest_phys_addr, memory.memory_size,
> +		memory.userspace_addr, memory.slot, memory.flags);
> +#endif
>   

Please wrap in a dprintf() macro or similar.


-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.