From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 7/9] register mmio slots Date: Sat, 20 Sep 2008 11:38:22 -0700 Message-ID: <48D5431E.9090102@redhat.com> References: <1221840506-22996-1-git-send-email-glommer@redhat.com> <1221840506-22996-8-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, aliguori@us.ibm.com To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:55680 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751289AbYITSjs (ORCPT ); Sat, 20 Sep 2008 14:39:48 -0400 In-Reply-To: <1221840506-22996-8-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: > By analysing phys_offset, we know whether a region is an mmio region > or not. If it is, register it as so. We don't reuse the same slot > infrastructure already existant, because there is a relationship between > the slot number for kvm the kernel module, and the index in the slots vector > for libkvm. However, we can do best in the future and use only a single data structure > for both. > > Why is kvm interested in emulated mmio regions, at all? > @@ -1032,11 +1042,9 @@ void kvm_mutex_lock(void) > > int qemu_kvm_register_coalesced_mmio(target_phys_addr_t addr, unsigned int size) > { > - return kvm_register_coalesced_mmio(kvm_context, addr, size); > } > > int qemu_kvm_unregister_coalesced_mmio(target_phys_addr_t addr, > unsigned int size) > { > - return kvm_unregister_coalesced_mmio(kvm_context, addr, size); > } > Why? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.