From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC] Extending MTRRs above 4G Date: Tue, 23 Sep 2008 12:19:16 +0300 Message-ID: <48D8B494.30905@redhat.com> References: <1221673872.16470.27.camel@lappy> <1221685501.16470.33.camel@lappy> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm To: Alex Williamson Return-path: Received: from mx2.redhat.com ([66.187.237.31]:41927 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbYIWJT0 (ORCPT ); Tue, 23 Sep 2008 05:19:26 -0400 In-Reply-To: <1221685501.16470.33.camel@lappy> Sender: kvm-owner@vger.kernel.org List-ID: Alex Williamson wrote: > On Wed, 2008-09-17 at 11:51 -0600, Alex Williamson wrote: > >> the patch below is a possible >> approach to continue down this path and enlighten rombios32 about the >> real top of memory, and setup MTRRs appropriately. It doesn't address >> SMBIOS or whatever causes grub to only report upper memory below 4G. >> > > This version also fixes SMBIOS, I'm haven't found where grub is getting > it's idea of upper memory yet. It seems like there's a bug in SMBIOS > type 19 & 20 entries that we were using (size_mb - 1) * 1024. I changed > this to (size_mb * 1024) - 1, which seems to make a lot more sense in > the dmidecode output. If that's wrong, please let me know. Thanks, > > Please resend as an independent patch. -- error compiling committee.c: too many arguments to function