From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Don't destroy vcpu in case vcpu_setup fails Date: Tue, 23 Sep 2008 12:21:51 +0300 Message-ID: <48D8B52F.9020505@redhat.com> References: <1221704219-21523-1-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, aliguori@codemonkey.ws To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:41973 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750738AbYIWJWD (ORCPT ); Tue, 23 Sep 2008 05:22:03 -0400 In-Reply-To: <1221704219-21523-1-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: > One of vcpu_setup responsibilities is to do mmu initialization. > However, in case we fail in kvm_arch_vcpu_reset, before we get the > chance to init mmu. OTOH, vcpu_destroy will attempt to destroy mmu, > triggering a bug. Keeping track of whether or not mmu is initialized > would unnecessarily complicate things. Rather, we just make return, > making sure any needed uninitialization is done before we return, in > case we fail. > Applied, thanks. -- error compiling committee.c: too many arguments to function