From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: libkvm: kvm_init: check kvm context allocation and zero it
Date: Tue, 23 Sep 2008 12:57:37 +0300
Message-ID: <48D8BD91.1040104@redhat.com>
References: <1213889188-29683-1-git-send-email-uril@qumranet.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: Uri Lublin <uril@qumranet.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:37811 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750959AbYIWJ5p (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 23 Sep 2008 05:57:45 -0400
In-Reply-To: <1213889188-29683-1-git-send-email-uril@qumranet.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Uri Lublin wrote:
> Signed-off-by: Uri Lublin <uril@qumranet.com>
> ---
>  libkvm/libkvm.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c
> index 1e7bbed..62bcb90 100644
> --- a/libkvm/libkvm.c
> +++ b/libkvm/libkvm.c
> @@ -243,6 +243,9 @@ kvm_context_t kvm_init(struct kvm_callbacks *callbacks,
>  	kvm_abi = r;
>  	kvm_page_size = getpagesize();
>  	kvm = malloc(sizeof(*kvm));
> +	if (kvm == NULL)
> +		goto out_close;
> +	memset(kvm, 0, sizeof(*kvm));
>  	kvm->fd = fd;
>  	kvm->vm_fd = -1;
>  	kvm->callbacks = callbacks;
>   

Applied, thanks.

-- 
error compiling committee.c: too many arguments to function