From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [patch 09/10] KVM: MMU: out of sync shadow core v2
Date: Tue, 23 Sep 2008 13:46:47 +0300
Message-ID: <48D8C917.1020104@redhat.com>
References: <20080918212749.800177179@localhost.localdomain> <20080918213337.148804603@localhost.localdomain> <48D4506C.5070804@redhat.com> <20080921004515.GC10120@dmt.cnet> <48D802EA.9070807@redhat.com> <20080922215503.GA27744@dmt.cnet> <20080922225137.GA1257@dmt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, "David S. Ahern" <daahern@cisco.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:41254 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752286AbYIWKqu (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 23 Sep 2008 06:46:50 -0400
In-Reply-To: <20080922225137.GA1257@dmt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Marcelo Tosatti wrote:
>> It restarts at parent level whenever finishing any children:
>>
>> +               if (i == PT64_ENT_PER_PAGE) {
>> +                       sp->unsync_children = 0;
>> +                       sp = parent;
>> +               }
>>
>> No efficiency.
>>     
>
> Do you prefer a recursive version for this one too? 
>
>   

Yes please.

-- 
error compiling committee.c: too many arguments to function