From: Anthony Liguori <anthony@codemonkey.ws>
To: Muli Ben-Yehuda <muli@il.ibm.com>
Cc: Amit Shah <amit.shah@redhat.com>,
avi@redhat.com, kvm@vger.kernel.org,
Ben-Ami Yassour1 <BENAMI@il.ibm.com>,
weidong.han@intel.com, allen.m.kay@intel.com
Subject: Re: [PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests
Date: Tue, 23 Sep 2008 14:58:04 -0500 [thread overview]
Message-ID: <48D94A4C.3050105@codemonkey.ws> (raw)
In-Reply-To: <20080923194302.GF6922@il.ibm.com>
Muli Ben-Yehuda wrote:
> On Tue, Sep 23, 2008 at 02:18:51PM -0500, Anthony Liguori wrote:
>
>
>> Make sure you issue iopl() before any of the VCPU threads are
>> spawned. Otherwise, you may be running into issues when something
>> other than VCPU-0 is doing PIO/MMIO and you haven't iopl()'d for
>> that thread.
>>
>
> Yeah, we thought of that, but as far as I can recall this happened
> with a single VCPU. In any case, we'll look into it again.
>
The io thread runs in a separate thread than the VCPU. So if you were
doing iopl(3) in the io thread (for instance, when called from
machine_init), then the VCPU thread wouldn't necessarily have inherited
the iopl().
You could also do it explicitly on vcpu thread construction.
Regards,
Anthony Liguori
> Cheers,
> Muli
>
next prev parent reply other threads:[~2008-09-23 19:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-23 14:54 [V6] Userspace patches for PCI device assignment Amit Shah
2008-09-23 14:54 ` [PATCH 1/7] KVM/userspace: Device Assignment: Add ioctl wrappers needed for assigning devices Amit Shah
2008-09-23 14:54 ` [PATCH 2/7] qemu: Introduce pci_map_irq to get irq nr from pin number for a PCI device Amit Shah
2008-09-23 14:54 ` [PATCH 3/7] qemu: piix: Introduce functions to get pin number from irq and vice versa Amit Shah
2008-09-23 14:54 ` [PATCH 4/7] qemu: Include hw.h in qemu/hw/isa.h to fix compile issues Amit Shah
2008-09-23 14:54 ` [PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests Amit Shah
2008-09-23 14:54 ` [PATCH 6/7] KVM/userspace: Build vtd.c for Intel IOMMU support Amit Shah
2008-09-23 14:54 ` [PATCH 7/7] KVM/userspace: Device Assignment: Support for hot plugging PCI devices Amit Shah
2008-09-23 16:32 ` Anthony Liguori
2008-09-24 4:24 ` Amit Shah
2008-09-23 16:31 ` [PATCH 6/7] KVM/userspace: Build vtd.c for Intel IOMMU support Anthony Liguori
2008-09-24 4:25 ` Amit Shah
2008-09-24 15:08 ` Anthony Liguori
2008-09-23 16:30 ` [PATCH 5/7] KVM/userspace: Device Assignment: Support for assigning PCI devices to guests Anthony Liguori
2008-09-23 18:32 ` Muli Ben-Yehuda
2008-09-23 19:18 ` Anthony Liguori
2008-09-23 19:43 ` Muli Ben-Yehuda
2008-09-23 19:58 ` Anthony Liguori [this message]
2008-09-24 4:58 ` Amit Shah
2008-09-24 15:07 ` Anthony Liguori
2008-09-24 17:10 ` Amit Shah
2008-09-25 4:54 ` Yang, Sheng
2008-09-25 5:20 ` Yang, Sheng
2008-09-26 1:34 ` Yang, Sheng
2008-09-23 16:13 ` [PATCH 4/7] qemu: Include hw.h in qemu/hw/isa.h to fix compile issues Anthony Liguori
2008-09-24 4:27 ` Amit Shah
2008-09-24 11:35 ` Amit Shah
2008-09-24 14:59 ` Anthony Liguori
2008-09-23 16:13 ` [PATCH 3/7] qemu: piix: Introduce functions to get pin number from irq and vice versa Anthony Liguori
2008-09-24 4:28 ` Amit Shah
2008-09-23 16:12 ` [PATCH 2/7] qemu: Introduce pci_map_irq to get irq nr from pin number for a PCI device Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D94A4C.3050105@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=BENAMI@il.ibm.com \
--cc=allen.m.kay@intel.com \
--cc=amit.shah@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=muli@il.ibm.com \
--cc=weidong.han@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).