[PATCH] VT-d: remove useless header inclusion

[PATCH] VT-d: remove useless header inclusion

[Han, Weidong]

[-- Attachment #1: Type: text/plain, Size: 650 bytes --]

Currently "#include <linux/intel-iommu.h>" is not needed in
virt/kvm/kvm_main.c. What's more, this inclusion may result in
compilation error in other architecture.

Signed-off-by: Weidong Han <weidong.han@intel.com>
---
 virt/kvm/kvm_main.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index cd34f73..6aa0e0f 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -41,7 +41,6 @@
 #include <linux/pagemap.h>
 #include <linux/mman.h>
 #include <linux/swap.h>
-#include <linux/intel-iommu.h>
 
 #include <asm/processor.h>
 #include <asm/io.h>
-- 
1.5.1

[-- Attachment #2: 0001-remove-useless-header-inclusion.patch --]
[-- Type: application/octet-stream, Size: 746 bytes --]

From 3f373dac7883ed2846436eb3006d9c666024660e Mon Sep 17 00:00:00 2001
From: Weidong Han <weidong.han@intel.com>
Date: Wed, 24 Sep 2008 13:39:57 +0800
Subject: [PATCH] remove useless header inclusion

Currently "#include <linux/intel-iommu.h>" is not needed in virt/kvm/kvm_main.c.

Signed-off-by: Weidong Han <weidong.han@intel.com>
---
 virt/kvm/kvm_main.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index cd34f73..6aa0e0f 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -41,7 +41,6 @@
 #include <linux/pagemap.h>
 #include <linux/mman.h>
 #include <linux/swap.h>
-#include <linux/intel-iommu.h>
 
 #include <asm/processor.h>
 #include <asm/io.h>
-- 
1.5.1

Re: [PATCH] VT-d: remove useless header inclusion

[Avi Kivity]

Han, Weidong wrote:
> Currently "#include <linux/intel-iommu.h>" is not needed in
> virt/kvm/kvm_main.c. What's more, this inclusion may result in
> compilation error in other architecture.
>
>   

Applied, but please also fix intel-iommu.h to compile on all archs.

-- 
error compiling committee.c: too many arguments to function

RE: [PATCH] VT-d: remove useless header inclusion

[Han, Weidong]

Avi Kivity wrote:
> Han, Weidong wrote:
>> Currently "#include <linux/intel-iommu.h>" is not needed in
>> virt/kvm/kvm_main.c. What's more, this inclusion may result in
>> compilation error in other architecture.
>> 
>> 
> 
> Applied, but please also fix intel-iommu.h to compile on all archs.

Avi,

Current intel-iommu.h should be compiled on all archs. On linux-next,
they moved __iommu_clflush_cache() definition to intel-iomm.h, which
results in it cannot pass compilation on some archs, such as IA64.

Randy (Weidong)

Re: [PATCH] VT-d: remove useless header inclusion

[Avi Kivity]

Han, Weidong wrote:
> Avi Kivity wrote:
>   
>> Han, Weidong wrote:
>>     
>>> Currently "#include <linux/intel-iommu.h>" is not needed in
>>> virt/kvm/kvm_main.c. What's more, this inclusion may result in
>>> compilation error in other architecture.
>>>
>>>
>>>       
>> Applied, but please also fix intel-iommu.h to compile on all archs.
>>     
>
> Avi,
>
> Current intel-iommu.h should be compiled on all archs. On linux-next,
> they moved __iommu_clflush_cache() definition to intel-iomm.h, which
> results in it cannot pass compilation on some archs, such as IA64.
>   

Well, it still wants fixing, even if it is in linux-next only.

-- 
error compiling committee.c: too many arguments to function