From: Avi Kivity <avi@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 0/4] Allow enabling kvm_trace on external module
Date: Wed, 24 Sep 2008 16:48:35 +0300 [thread overview]
Message-ID: <48DA4533.6040303@redhat.com> (raw)
In-Reply-To: <1222105928-23813-1-git-send-email-ehabkost@redhat.com>
Eduardo Habkost wrote:
> This series adds compat code to allow enabling kvm_trace when building
> KVM as an external module on older kernels.
>
> The most hackish part is the last patch, that adds --with-kvm-trace to
> configure and adds an include to a generated file on kernel/x86/Kbuild. It
> doesn't look pretty, so suggestions on how to make this better are
> welcome.
>
Applied all, thanks. We could improve Kbuild by having kernel/Makefile
include config.mak and pass some variable to Kbuild somehow, but diving
into Kbuild isn't my idea of a week well spent.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-09-24 13:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 17:52 [PATCH 0/4] Allow enabling kvm_trace on external module Eduardo Habkost
2008-09-22 17:52 ` [PATCH 1/4] Add kvm_trace.c to hack-files-x86 Eduardo Habkost
2008-09-22 17:52 ` [PATCH 2/4] Hack DEFINE_SIMPLE_ATTRIBUTE for lost_records_get() also Eduardo Habkost
2008-09-22 17:52 ` [PATCH 3/4] relay_open() compat Eduardo Habkost
2008-09-24 13:50 ` Avi Kivity
2008-09-22 17:52 ` [PATCH 4/4] Add --with-kvm-trace arg to configure Eduardo Habkost
2008-09-24 13:48 ` Avi Kivity [this message]
2008-09-24 17:26 ` [PATCH 0/4] Allow enabling kvm_trace on external module Eduardo Habkost
2008-09-25 11:25 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48DA4533.6040303@redhat.com \
--to=avi@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).