From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/4] Allow enabling kvm_trace on external module Date: Wed, 24 Sep 2008 16:48:35 +0300 Message-ID: <48DA4533.6040303@redhat.com> References: <1222105928-23813-1-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Eduardo Habkost Return-path: Received: from mx2.redhat.com ([66.187.237.31]:50722 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751166AbYIXNsk (ORCPT ); Wed, 24 Sep 2008 09:48:40 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m8ODmdvO002082 for ; Wed, 24 Sep 2008 09:48:39 -0400 In-Reply-To: <1222105928-23813-1-git-send-email-ehabkost@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Eduardo Habkost wrote: > This series adds compat code to allow enabling kvm_trace when building > KVM as an external module on older kernels. > > The most hackish part is the last patch, that adds --with-kvm-trace to > configure and adds an include to a generated file on kernel/x86/Kbuild. It > doesn't look pretty, so suggestions on how to make this better are > welcome. > Applied all, thanks. We could improve Kbuild by having kernel/Makefile include config.mak and pass some variable to Kbuild somehow, but diving into Kbuild isn't my idea of a week well spent. -- error compiling committee.c: too many arguments to function