From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 4/7] qemu: Include hw.h in qemu/hw/isa.h to fix compile issues Date: Wed, 24 Sep 2008 09:59:42 -0500 Message-ID: <48DA55DE.4040304@codemonkey.ws> References: <1222181695-23418-1-git-send-email-amit.shah@redhat.com> <1222181695-23418-5-git-send-email-amit.shah@redhat.com> <48D915B8.6040401@codemonkey.ws> <200809240957.39770.amit.shah@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: avi@redhat.com, kvm@vger.kernel.org, muli@il.ibm.com, benami@il.ibm.com, weidong.han@intel.com, allen.m.kay@intel.com To: Amit Shah Return-path: Received: from yx-out-2324.google.com ([74.125.44.30]:40642 "EHLO yx-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751922AbYIXPAm (ORCPT ); Wed, 24 Sep 2008 11:00:42 -0400 Received: by yx-out-2324.google.com with SMTP id 8so408561yxm.1 for ; Wed, 24 Sep 2008 08:00:41 -0700 (PDT) In-Reply-To: <200809240957.39770.amit.shah@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Amit Shah wrote: > * On Tuesday 23 Sep 2008 21:43:44 Anthony Liguori wrote: > >> Amit Shah wrote: >> >>> Signed-off-by: Amit Shah >>> --- >>> qemu/hw/isa.h | 2 ++ >>> 1 files changed, 2 insertions(+), 0 deletions(-) >>> >>> diff --git a/qemu/hw/isa.h b/qemu/hw/isa.h >>> index 222e4f3..e4a1326 100644 >>> --- a/qemu/hw/isa.h >>> +++ b/qemu/hw/isa.h >>> @@ -2,6 +2,8 @@ >>> #define HW_ISA_H >>> /* ISA bus */ >>> >>> +#include "hw.h" >>> + >>> extern target_phys_addr_t isa_mem_base; >>> >>> int register_ioport_read(int start, int length, int size, >>> >> What compile issues? >> > > register_ioport_read* and register_ioport_write* functions cause a lot of > this. > You could also address this by including hw.h before including isa.h. Basically, everything should include "qemu-common.h" and anything that's implemented emulated hardware should include "hw.h" before including anything else. It's not perfect, but it's how things are right now. Regards, Anthony Liguori