From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 10/11] VMX: work around lacking VNMI support Date: Thu, 25 Sep 2008 13:31:39 +0300 Message-ID: <48DB688B.6020307@redhat.com> References: <48D74CE6.5060008@siemens.com> <48D7504B.7050102@siemens.com> <48DB5CC3.5010104@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: "Yang, Sheng" , Gleb Natapov , kvm-devel To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:39103 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753175AbYIYKbs (ORCPT ); Thu, 25 Sep 2008 06:31:48 -0400 In-Reply-To: <48DB5CC3.5010104@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > Jan Kiszka wrote: > .. > >> Index: b/arch/x86/kvm/vmx.c >> =================================================================== >> --- a/arch/x86/kvm/vmx.c >> +++ b/arch/x86/kvm/vmx.c >> @@ -90,6 +90,11 @@ struct vcpu_vmx { >> } rmode; >> int vpid; >> bool emulation_required; >> + >> + /* Support for vnmi-less CPUs */ >> + int soft_vnmi_blocked; >> + ktime_t entry_time; >> + s64 vnmi_blocked_time; >> > > I meanwhile realized that these states (except entry_time) and probably > also arch.nmi_pending/injected are things that should be considered when > the vcpu state is saved and restored, right? What is the right interface > for this? An extension of kvm_sregs? > > kvm_sregs can't be extended because that would break the ABI, so we have to add a new ioctl. I have some patches that allow ioctls to be extended, so if that's accepted, we can avoid the new ioctl. > BTW, via which channel is GUEST_INTERRUPTIBILITY_INFO from the vmcs > saved/restored? I'm currently not seeing any related, CPU-specific code. > Looks like it's missing. -- error compiling committee.c: too many arguments to function