From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Subject: Re: change in 'smp_cpus' at runtime vs vcpu_info? Date: Fri, 26 Sep 2008 16:31:41 +0200 Message-ID: <48DCF24D.5080709@sgi.com> References: <48DCEEDD.4000901@sgi.com> <5d6222a80809260728q214c93ddt12f6981cf4780259@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Glauber Costa Return-path: Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:50488 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752463AbYIZObn (ORCPT ); Fri, 26 Sep 2008 10:31:43 -0400 In-Reply-To: <5d6222a80809260728q214c93ddt12f6981cf4780259@mail.gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: > On Fri, Sep 26, 2008 at 11:17 AM, Jes Sorensen wrote: >> Hi, >> >> Looking through the KVM qemu code, I see nothing that indicates that >> smp_cpus can be increased after qemu is initially launched? >> >> Does anyone see any reason why we couldn't allocate the vcpu_info >> array at launch time based on the value of smp_cpus? Right now >> vcpu_info is a static array and I would love to get rid of this >> limitation if possible. > > it can increase in hw/apic.c. The real limitation is then in the bios. > The APIC tables > used to be populated based on the smp_cpus value, and now are populated based on > MAX_CPUS. Hmmm. I don't see any reference to MAX_CPUS in hw/apic.c, any chance you can give me a pointer? Thanks, Jes