From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Subject: Re: change in 'smp_cpus' at runtime vs vcpu_info? Date: Fri, 26 Sep 2008 16:46:25 +0200 Message-ID: <48DCF5C1.3000205@sgi.com> References: <48DCEEDD.4000901@sgi.com> <5d6222a80809260728q214c93ddt12f6981cf4780259@mail.gmail.com> <48DCF24D.5080709@sgi.com> <5d6222a80809260739i4eb39d6fn6a26027c9646383a@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Glauber Costa Return-path: Received: from relay2.sgi.com ([192.48.171.30]:55155 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752749AbYIZOq1 (ORCPT ); Fri, 26 Sep 2008 10:46:27 -0400 In-Reply-To: <5d6222a80809260739i4eb39d6fn6a26027c9646383a@mail.gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: > On Fri, Sep 26, 2008 at 11:31 AM, Jes Sorensen wrote: >> Hmmm. I don't see any reference to MAX_CPUS in hw/apic.c, any chance you >> can give me a pointer? > > sorry. That's not apic (damn acronyms), It's acpi. > But the reference to MAX_CPUS is at bios/rombios32.c when building the tables. > the acpi code just fire them out. Oh, that seems to be x86 gibberish though :-) Well the point is that qemu-kvm.c seems to loop over the vcpu_info array based on smp_cpus, so if we hotplug a CPU and smp_cpus isn't updated, which I cannot find any place that does, then we'll end up looping over only a subset of cpus? or am I missing something here? Cheers, Jes