From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch] stop passing in global variable as argument to cmos_init() Date: Sat, 27 Sep 2008 13:51:31 +0300 Message-ID: <48DE1033.5020704@redhat.com> References: <48DCDD8E.4070409@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, kvm-ia64@vger.kernel.org To: Jes Sorensen Return-path: Received: from mx2.redhat.com ([66.187.237.31]:38249 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbYI0Kva (ORCPT ); Sat, 27 Sep 2008 06:51:30 -0400 In-Reply-To: <48DCDD8E.4070409@sgi.com> Sender: kvm-owner@vger.kernel.org List-ID: Jes Sorensen wrote: > Hi, > > Looking through the ia64 code I came across this little gem. > > At some point someone added a new argument to hw/pc.c:cmos_init() named > 'smp_cpus', and then passed in the global variable 'smp_cpus' as the > argument. This propagated through to the ia64 code as well. > > I checked, this isn't present in the upstream QEMU code, so lets kill > it in the KVM branch. One small step to get closer to upstream :-) > Applied, thanks (though personally I prefer not depending on global variables and their initialization order, etc.) -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.