From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 4/9] Implement GIF, clgi and stgi v3 Date: Sat, 27 Sep 2008 15:52:50 +0300 Message-ID: <48DE2CA2.60507@redhat.com> References: <1221658886-14109-1-git-send-email-agraf@suse.de> <1221658886-14109-2-git-send-email-agraf@suse.de> <1221658886-14109-3-git-send-email-agraf@suse.de> <1221658886-14109-4-git-send-email-agraf@suse.de> <1221658886-14109-5-git-send-email-agraf@suse.de> <20080925184759.GL27426@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexander Graf , kvm@vger.kernel.org, anthony@codemonkey.ws To: Joerg Roedel Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42315 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752191AbYI0Mwz (ORCPT ); Sat, 27 Sep 2008 08:52:55 -0400 In-Reply-To: <20080925184759.GL27426@8bytes.org> Sender: kvm-owner@vger.kernel.org List-ID: Joerg Roedel wrote: > I had another possible idea for performance improvement here. Since we > only inject normal interrupts and exceptions (and not NMI and such) we > can patch clgi to cli and stgi to sti to save these two intercepts in > the guests vmrun path. > Any objections/problems with this? > > The sequence 'clgi; sti' will break. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.