From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 4/4] kvm: bios: switch MTRRs to cover only the PCI range and default to WB Date: Sat, 27 Sep 2008 16:36:01 +0300 Message-ID: <48DE36C1.4070700@redhat.com> References: <1222365149.8138.266.camel@2710p.home> <200809271335.10166.sheng.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Alex Williamson To: "Yang, Sheng" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:59195 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752506AbYI0NgA (ORCPT ); Sat, 27 Sep 2008 09:36:00 -0400 In-Reply-To: <200809271335.10166.sheng.yang@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Yang, Sheng wrote: > I think we should do a little more than just write msr to update mtrr. > > Intel SDM 10.11.8 "MTRR consideration in MP Systems" define the procedure to > modify MTRR msr in MP. Especially, step 4 enter no-fill cache mode(set CR0.CD > bit and clean NW bit), step 12 re-enabled the caching(clear this two bits). > > We based on these behaviors to detect MTRR update. > > Why not simply flush the mmu on an mtrr write? (though of course I have no objection to doing what the manual says) -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.