From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] VT-d: Fix iommu map page for mmio pages Date: Sun, 28 Sep 2008 11:45:32 +0300 Message-ID: <48DF442C.4070002@redhat.com> References: <0122C7C995D32147B66BF4F440D3016301BE2C10@pdsmsx415.ccr.corp.intel.com> <48DB6777.7070709@redhat.com> <0122C7C995D32147B66BF4F440D3016301C7D0EB@pdsmsx415.ccr.corp.intel.com> <48DB98FD.3000307@redhat.com> <0122C7C995D32147B66BF4F440D3016301C7D0FF@pdsmsx415.ccr.corp.intel.com> <48DBA40A.7030508@redhat.com> <20080925211423.GC6788@il.ibm.com> <48DC07DC.2010201@codemonkey.ws> <20080926235730.GE9118@il.ibm.com> <48DE09DF.2050400@redhat.com> <20080928060753.GD7239@il.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , kvm@vger.kernel.org, Amit Shah , "Kay, Allen M" , Ben-Ami Yassour1 To: Muli Ben-Yehuda Return-path: Received: from mx2.redhat.com ([66.187.237.31]:34092 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172AbYI1IqE (ORCPT ); Sun, 28 Sep 2008 04:46:04 -0400 In-Reply-To: <20080928060753.GD7239@il.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: Muli Ben-Yehuda wrote: > On Sat, Sep 27, 2008 at 01:24:31PM +0300, Avi Kivity wrote: > > >>> I strongly disagree. You are advocating something that is >>> potentially unsafe---for the sake of code simplicity?! I am >>> advocating caution in what we let an *untrusted* guest do. >>> >> Why would it be unsafe? >> > > Because on at least one machine letting a device DMA to the same > address as another device's MMIO region caused the machine to reboot. > That sounds like a hardware bug. What does the vendor say about this? -- error compiling committee.c: too many arguments to function