* libkvm: kvm_dirty_pages_log_change: do not forget to set .slot
@ 2008-09-28 14:32 Uri Lublin
2008-09-28 15:10 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Uri Lublin @ 2008-09-28 14:32 UTC (permalink / raw)
To: kvm; +Cc: Uri Lublin
The default for .slot is 0, which is wrong for all other kvm-slots.
This fixes enabling/disabling kvm dirty page logging.
Signed-off-by: Uri Lublin <uril@qumranet.com>
---
libkvm/libkvm.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c
index 88d3f5d..dfa63bb 100644
--- a/libkvm/libkvm.c
+++ b/libkvm/libkvm.c
@@ -172,6 +172,7 @@ static int kvm_dirty_pages_log_change(kvm_context_t kvm, unsigned long phys_addr
{
struct kvm_userspace_memory_region mem = {
+ .slot = slot,
.memory_size = slots[slot].len,
.guest_phys_addr = slots[slot].phys_addr,
.userspace_addr = slots[slot].userspace_addr,
--
1.6.0.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: libkvm: kvm_dirty_pages_log_change: do not forget to set .slot
2008-09-28 14:32 libkvm: kvm_dirty_pages_log_change: do not forget to set .slot Uri Lublin
@ 2008-09-28 15:10 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2008-09-28 15:10 UTC (permalink / raw)
To: Uri Lublin; +Cc: kvm
Uri Lublin wrote:
> The default for .slot is 0, which is wrong for all other kvm-slots.
>
> This fixes enabling/disabling kvm dirty page logging.
>
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-28 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-28 14:32 libkvm: kvm_dirty_pages_log_change: do not forget to set .slot Uri Lublin
2008-09-28 15:10 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).