From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Re: [PATCH 0/5] bios: >4G updates Date: Sun, 28 Sep 2008 18:19:48 +0300 Message-ID: <48DFA094.6040208@redhat.com> References: <1222188118.8138.101.camel@2710p.home> <48DA1F6A.40105@redhat.com> <1222273063.16470.157.camel@lappy> <1222358913.8138.245.camel@2710p.home> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel , gleb@redhat.com To: Alex Williamson Return-path: Received: from mx2.redhat.com ([66.187.237.31]:48763 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721AbYI1PTx (ORCPT ); Sun, 28 Sep 2008 11:19:53 -0400 In-Reply-To: <1222358913.8138.245.camel@2710p.home> Sender: kvm-owner@vger.kernel.org List-ID: Alex Williamson wrote: > I guess the SSDT support was prior to the last merge, and appropriately > dropped. The most interesting new feature is a boot menu to allow the > user to override the boot device. That seems pretty useful. Other > things like better printing of the devices and support for PIIX4 could > come in handy too. So yeah, it looks worth merging. I can drop my > first two patches and rework the others so we don't cause unnecessary > merge problems. > I tried to merge it, but it the new bios won't boot. I traced this to ata_reset: it toggles the soft reset bit in the command register and expects to see the busy bit set, but the ide device model returns zero status if the selected device has no drive. No idea if the device model or the bios is wrong. If anyone (hi Gleb) wants to take a look, it's in the branch bios-merge on git.kernel.org. btw, commenting this out leads to boot failure as well, but that may be related. -- error compiling committee.c: too many arguments to function