From: Avi Kivity <avi@redhat.com>
To: Alex Williamson <alex.williamson@hp.com>
Cc: kvm-devel <kvm@vger.kernel.org>, gleb@redhat.com
Subject: Re: Re: [PATCH 0/5] bios: >4G updates
Date: Tue, 30 Sep 2008 19:46:31 +0300 [thread overview]
Message-ID: <48E257E7.8000600@redhat.com> (raw)
In-Reply-To: <48E22A32.7060007@redhat.com>
Avi Kivity wrote:
> Avi Kivity wrote:
>>
>> I tried to merge it, but it the new bios won't boot. I traced this
>> to ata_reset: it toggles the soft reset bit in the command register
>> and expects to see the busy bit set, but the ide device model returns
>> zero status if the selected device has no drive.
>>
>> No idea if the device model or the bios is wrong.
>>
>> If anyone (hi Gleb) wants to take a look, it's in the branch
>> bios-merge on git.kernel.org.
>>
>> btw, commenting this out leads to boot failure as well, but that may
>> be related.
>>
>
> Okay, I think I have it -- the bios code was using .org to set certain
> entry points to well known addresses, and one code section overflowed
> due to enabling the cache, which is a kvm addition. Moving that bit
> out-of-line allows the bios to boot.
>
It works, so I pushed it out. Alex, can you rebase your bios patches on
top of current HEAD?
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2008-09-30 16:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-23 16:41 [PATCH 0/5] bios: >4G updates Alex Williamson
2008-09-24 11:07 ` Avi Kivity
2008-09-24 16:17 ` Alex Williamson
2008-09-25 16:08 ` Alex Williamson
2008-09-28 15:19 ` Avi Kivity
2008-09-30 13:31 ` Avi Kivity
2008-09-30 16:46 ` Avi Kivity [this message]
2008-09-30 21:19 ` Alex Williamson
2008-10-02 12:33 ` Avi Kivity
2008-10-12 22:50 ` Kevin O'Connor
2008-10-13 6:45 ` Gleb Natapov
2008-10-14 15:29 ` Avi Kivity
2008-10-14 16:00 ` Anthony Liguori
2008-10-14 16:17 ` Avi Kivity
2008-10-14 16:21 ` Glauber Costa
2008-10-15 0:41 ` Kevin O'Connor
2008-10-15 17:46 ` Avi Kivity
2008-10-16 0:31 ` Kevin O'Connor
2008-10-13 16:33 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E257E7.8000600@redhat.com \
--to=avi@redhat.com \
--cc=alex.williamson@hp.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).